----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171230 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 289 (patched) <https://reviews.apache.org/r/58221/#comment244109> According to the code style guide, the opening brace should be at the same line with the function. ``` privated void startHMSFollower(Configuration conf) { ... ``` sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 301 (patched) <https://reviews.apache.org/r/58221/#comment244110> Please also log the exception. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 307 (patched) <https://reviews.apache.org/r/58221/#comment244111> Please put open brace to the same line as the function signature. Also there should be a space between `if` and parenthesis. Please remove the blank line at line 313. - Lei Xu On April 5, 2017, 3:29 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 3:29 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db635f639cef91ce675d34d717e6125a0a4d1 > > > Diff: https://reviews.apache.org/r/58221/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
