> On April 10, 2017, 6:50 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Line 312 (original), 317 (patched) > > <https://reviews.apache.org/r/58221/diff/2-3/?file=1686253#file1686253line320> > > > > Should we have a new config specific for timeout?
I thought about that option. Scheduling interval is a good upper limit on how long the task can run since the HMSFollower will be scheduled based on that interval. So I opt to not have another configuration for this operation. > On April 10, 2017, 6:50 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 325 (patched) > > <https://reviews.apache.org/r/58221/diff/3/?file=1686519#file1686519line337> > > > > Should we call hmsFollower.stop(); before terminate hmsFollowerExecutor? I thought about this option. In the current approach, terminate HmsFollowerExecutor will stop scheduling HMSFollower. Then we can close all connections. There should be no issue. If we close all connections first (call hmsFollower.stop(); before terminate hmsFollowerExecutor), it is possible that HMSFollower is scheduled, and then connections are created again. That is not desirable. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171459 ----------------------------------------------------------- On April 7, 2017, 5:23 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 7, 2017, 5:23 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 6c14f5e46aad4223347d8d057188d31efbb68ed8 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db635f639cef91ce675d34d717e6125a0a4d1 > > > Diff: https://reviews.apache.org/r/58221/diff/3/ > > > Testing > ------- > > > Thanks, > > Na Li > >
