> On April 10, 2017, 12:58 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > > Lines 87 (patched) > > <https://reviews.apache.org/r/58281/diff/1/?file=1686601#file1686601line87> > > > > I agree, functionally this approach will solve ths issue. but this > > approach will create performance issues under traffic. > > > > My statement makes more sence for PERM updates. > > > > I have not looked at the logic in namenode plug-in. If we can change > > that logic to handle monotonically increasing change ID's, that is best way > > to go.
+1. I agree that this is not the most performant solution, as I hesitated to do so in the first place. Do you know that whether it is applicable to build trigger SQL for each table for every supported DB, that only sets the change ID when the record is inserted successfully? - Lei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58281/#review171464 ----------------------------------------------------------- On April 10, 2017, 12:54 p.m., Lei Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58281/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 12:54 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1643 > https://issues.apache.org/jira/browse/SENTRY-1643 > > > Repository: sentry > > > Description > ------- > > When it relies on the SQL auto increment primary key as ChangeID, it can not > guarentee the consectivity of the IDs, because while each transaction claims > new ID from the table counter, the concurrent transactions which were not > success would not return the claimed changeIDs to the pool, thus it can not > guarateen the consectivity of change IDs. > > This patch changes to use application logic to force the consectivity of IDs. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java > a0d34459d7b2f70e863ef6e078401df81381c91b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPermChange.java > 476fbcb2ad26de23757842111beb12b154e1562b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/DeltaTransactionBlock.java > f590a5296c047e1acedd39a4f2e4f1de98008d32 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 802b9c6cbf8e9ad015e37037b809b58c956de746 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > aaa0b9fd30bb68fded67f885af4f77bc71398e77 > > > Diff: https://reviews.apache.org/r/58281/diff/2/ > > > Testing > ------- > > Add a new test to conurrently insert changes. > > mvn test -Dtest=TestSentryStore. > > > Thanks, > > Lei Xu > >
