> On April 12, 2017, 4:50 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 78 (patched) > > <https://reviews.apache.org/r/58221/diff/5/?file=1689530#file1689530line78> > > > > Do you ever expect concurrent calls to close() or not? > > Na Li wrote: > It is possible. I will add "synchronized" in front of it. > > Alexander Kolbasov wrote: > Under what circumstances is it possible? If it is possible, it may not be > sufficient to add synchronized() - you may need to protect access to the > variables as well, but I a not convinced that it is possible. Do we run our > tests in parallel? > > Na Li wrote: > I am not familar with how Sentry service is actually used. > Hypathetically, it is possible that several threads hold the same instance > and call its close() concurrently.
This should never hapen during regular use - I think this may only happen if tests are running in parallel but I guess that it will break many things. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171666 ----------------------------------------------------------- On April 13, 2017, 4:47 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 13, 2017, 4:47 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/7/ > > > Testing > ------- > > > Thanks, > > Na Li > >
