> On April 14, 2017, 12:57 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 370 (patched) > > <https://reviews.apache.org/r/58221/diff/9/?file=1692270#file1692270line398> > > > > Do we need to call awaitTermination() after shutdownNow()? This is > > existing code, but still. > > Na Li wrote: > I don't know the reason why
I talked to Kalyan. He mentioned that it is realted to database update. We want to let it end gracefully. > On April 14, 2017, 12:57 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 425 (patched) > > <https://reviews.apache.org/r/58221/diff/9/?file=1692270#file1692270line454> > > > > The code uses synchronized() on both, so the comment isn't quite right > > - it would handle concurrent calls to start()/stop() - not that it is > > needed. > > Na Li wrote: > the synchronized is orignal. You mentioned if multiple threads accese it > at the same time, since we don't protect variables, it is still not thread > safe. do you want me to remove the comment? - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171970 ----------------------------------------------------------- On April 14, 2017, 8:36 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 14, 2017, 8:36 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/11/ > > > Testing > ------- > > > Thanks, > > Na Li > >
