> On April 14, 2017, 11:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2511 (patched) > > <https://reviews.apache.org/r/58412/diff/1/?file=1691537#file1691537line2511> > > > > Currently this method gets called while processing CREATE_DATABASE, > > CREATE_TABLE and ADD_PARTITION events. > > > > On receiving CREATE_DATABASE, CREATE_TABLE events, > > mAuthzPathsMapping entry is not expected. If we find any we should log > > an error. > > > > On receiving CREATE_DATABASE, CREATE_TABLE events, you may want to call > > createAuthzPathsMappingCore method instead.
Create_database and alike should not call createAuthzPathsMappingCore. createAuthzPathsMappingCore is only for persisting full snapshot that gets from HMS from the first startup. This method will throw exceptions if the authzObj exist in the mapping which is likely to happen for create_database or alike. > On April 14, 2017, 11:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 394 (original), 384 (patched) > > <https://reviews.apache.org/r/58412/diff/1/?file=1691538#file1691538line402> > > > > When a view is created, location will be empty. Such events should be > > ignored instead of throwing exceptions. The current HMS side plugin(before HA) is not handling view. If we want to extend it to handle view events it would be better to handle it in follow up jira(SENTRY-1693). - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172039 ----------------------------------------------------------- On April 13, 2017, 6:58 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58412/ > ----------------------------------------------------------- > > (Updated April 13, 2017, 6:58 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > [WIP]SENTRY-1587: Refactor SentryStore transaction to persist a single path > transcation bundled with corresponding delta path change > > Change-Id: Ice77f631e92c0e74b42ae644e1b2f90c6089e62f > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > 90aaaef0e15306627d7108f12a74a29848055c0b > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > 14e967aa1065f16e8d4c3f61db2f9055959fa9e6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > c22364fa26c80415827313f4d26f6c53b71b6f6c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > aaea9790282f9136302eec64107cc86391a4d6ff > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb13b0d5015aefe892a6f7e46812ea75124 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 31a309bdc789bd7a997f7654e30f2021ecb5b616 > > > Diff: https://reviews.apache.org/r/58412/diff/1/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
