> On April 17, 2017, 5:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 107 (patched) > > <https://reviews.apache.org/r/58221/diff/11/?file=1692818#file1692818line107> > > > > Please add comment explaining how do you use the future.
I will remove the future since in the latest build, calling startSentryStoreCleaner only at runServer() does not cause test failure. So I will simplify the code. > On April 17, 2017, 5:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 282 (patched) > > <https://reviews.apache.org/r/58221/diff/11/?file=1692818#file1692818line308> > > > > Please add clarifying parenthesis: > > > > if (notificationLogEnabled && (hmsFollowerExecutor == null) && > > (hmsFollower != null)) { It is done > On April 17, 2017, 5:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 292 (patched) > > <https://reviews.apache.org/r/58221/diff/11/?file=1692818#file1692818line318> > > > > We can't handle this - if HMSFollowert should start and it doesn't, > > SentryService should fail. The easiest thing may be just to propagate the > > exception up the chain. I rethrow the exception > On April 17, 2017, 5:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 343 (patched) > > <https://reviews.apache.org/r/58221/diff/11/?file=1692818#file1692818line369> > > > > You can move this outside the try block and return immediately if > > storeCleanPeriodSecs <= 0. This will simplify the code a bit. it is done. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review172104 ----------------------------------------------------------- On April 18, 2017, 3:46 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58221/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 3:46 a.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-1649 move HMS follower to runServer > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 16676fb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 132db63 > > > Diff: https://reviews.apache.org/r/58221/diff/15/ > > > Testing > ------- > > > Thanks, > > Na Li > >