----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58799/#review173402 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PolicyFiles.java Line 45 (original), 44 (patched) <https://reviews.apache.org/r/58799/#comment246399> Do you need to close the output stream? sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PolicyFiles.java Line 67 (original), 66 (patched) <https://reviews.apache.org/r/58799/#comment246400> THis would cause a double-close of input - Alexander Kolbasov On April 27, 2017, 2:50 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58799/ > ----------------------------------------------------------- > > (Updated April 27, 2017, 2:50 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1730 > https://issues.apache.org/jira/browse/SENTRY-1730 > > > Repository: sentry > > > Description > ------- > > This task is to remove FileInputStream/FileOutputStream due to reasons > outlined here: > > https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java > c1518ba3 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PolicyFiles.java > 4a632bc9 > > > Diff: https://reviews.apache.org/r/58799/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
