> On May 8, 2017, 11:28 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 386 (patched) > > <https://reviews.apache.org/r/59058/diff/1/?file=1710733#file1710733line386> > > > > This approach is also not efficient. Let's say there are N > > notifications and the HMSFollower raises exception while processing 1st > > notificaition. This approach stops processing rest of the notifications > > until the HMSFollower is run again.
The catch clause does not throw exception, so after finally, the processing will continue for next event in the same run. If the catch clause throws the catched exception, then the behavior will be what you mentioned - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59058/#review174241 ----------------------------------------------------------- On May 8, 2017, 6:07 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59058/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 6:07 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: sentry-1752 > https://issues.apache.org/jira/browse/sentry-1752 > > > Repository: sentry > > > Description > ------- > > Catch exception in processing notification event and move on. Add unit test > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > e271ea4 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > fd97936 > > > Diff: https://reviews.apache.org/r/59058/diff/1/ > > > Testing > ------- > > add unit test > > > Thanks, > > Na Li > >
