> On May 11, 2017, 4:25 p.m., Sergio Pena wrote: > > Colm, the changes look good. Just a quetion, how do I test this change > > works? > > > > I run 'mvn clean install -DskipTests -Psign-artifacts', but I get an error > > that the gpg key does not exist. > > > > I run 'mvn clean package -DskipTests -Psign-artifacts' and all works, but > > I'm not sure if the .tar.gz were signed. > > I was following the 'how to release' section of the wiki, but those > > commands do not work.
You need to have gpg installed on your machine + a keypair set up for it to work (see here: https://www.apache.org/dev/openpgp.html). After it runs successfully you should see ".asc" files, for example: sentry-dist/target/apache-sentry-1.8.0-SNAPSHOT-bin.tar.gz.asc - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59084/#review174669 ----------------------------------------------------------- On May 9, 2017, 9:02 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59084/ > ----------------------------------------------------------- > > (Updated May 9, 2017, 9:02 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1516 > https://issues.apache.org/jira/browse/SENTRY-1516 > > > Repository: sentry > > > Description > ------- > > Add gpg configuration to the root pom to enable deployment to Maven Central. > > > Diffs > ----- > > pom.xml f513487 > > > Diff: https://reviews.apache.org/r/59084/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
