> On May 10, 2017, 9:31 p.m., Alexander Kolbasov wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> > Lines 138 (patched)
> > <https://reviews.apache.org/r/59120/diff/3/?file=1714167#file1714167line146>
> >
> > We have two cases here:
> >
> > 1) In production setup this is a fatal error (when HMS is configured)
> > so this should be LOGGER.error() followed by an appropriate exception
> > 2) In tests this is totally Ok but we do not want to print this every
> > time run() is executed.
> >
> > Is there some way to distinguish between these two cases?
>
> Na Li wrote:
> I think we can put all setup (such as saving configuration into
> hive-site.xml) before creating sentry server. In this way, production and
> testing will behave the same. And we don't need to differentiate them.
>
> Na Li wrote:
> The order of setup() in test will be
> 1. Create sentryservice (not start sentryservice)
> 2. configure Hive and start Hive
> 3. start sentryservice
the order that works is
// Create Sentry
createSentry();
// Start HDFS and MR
startDFSandYARN();
// Configure Hive and Metastore
HiveConf hiveConf = configureHiveAndMetastore();
// Start Sentry
startSentry();
// Start Hive and Metastore
startHiveAndMetastore(hiveConf);
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59120/#review174565
-----------------------------------------------------------
On May 12, 2017, 3:40 a.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59120/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 3:40 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and
> Sergio Pena.
>
>
> Bugs: sentry-1757
> https://issues.apache.org/jira/browse/sentry-1757
>
>
> Repository: sentry
>
>
> Description
> -------
>
> use hive configuration to check.
>
>
> Diffs
> -----
>
>
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java
> 431c7fe
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> 9880c40
>
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java
> 1530eb2
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
> 7d128b7
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
> 32acc65
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
> 548dcf8
>
>
> Diff: https://reviews.apache.org/r/59120/diff/5/
>
>
> Testing
> -------
>
> integration test TestHDFSIntegrationEnd2End
>
>
> Thanks,
>
> Na Li
>
>
