> On May 12, 2017, 3:28 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > > Lines 144 (patched) > > <https://reviews.apache.org/r/59174/diff/1/?file=1715267#file1715267line144> > > > > waiting for 5000 seconds seems really long. are you sure the unit is > > seconds instead of ms?
It shouldn't be that long. I agree. Will fix it. > On May 12, 2017, 3:28 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > > Lines 149 (patched) > > <https://reviews.apache.org/r/59174/diff/1/?file=1715267#file1715267line149> > > > > why do you need this? Will remove. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59174/#review174798 ----------------------------------------------------------- On May 11, 2017, 12:51 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59174/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 12:51 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1761 > https://issues.apache.org/jira/browse/SENTRY-1761 > > > Repository: sentry > > > Description > ------- > > Added test to make sure that SENTRY_HMS_NOTIFICATION_ID table is properly > updated even when multiple HMSFollowers are processing notifications from HMS. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestConcurrentHMSFollowers.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59174/diff/2/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
