----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59274/ -----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na Li. Bugs: SENTRY-1760 https://issues.apache.org/jira/browse/SENTRY-1760 Repository: sentry Description ------- The patch will set the 'needHiveSnapshot' to TRUE whenever the following cases are found: - List of notifications received are different than expected. This may happen when Sentry has been down or HDFS sync was disabled for a while (more than 24h), and the HMS cleared old notifications (older than 24h) not processed by Sentry causing a gap when retrieving notifications. - Latest Sentry notification ID processed is bigger than current HMS notification ID. This may happen when the HMS DB data was reset or restore from an old snapshot causing sync issues with Sentry. When needHiveSnapshot is set to TRUE, then the HMSFollower will CLEAR any hive snapshot stored on the Sentry store, and recreate a new hive snapshot from scratch to keep Sentry in sync. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ef6786537e9c5f7730bc86d44e8b4a168c20677e sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 5e6b906587f6422d9bf1466ab83815722bd51fb0 Diff: https://reviews.apache.org/r/59274/diff/1/ Testing ------- HadoopQA is GREEN. Thanks, Sergio Pena