> On May 10, 2017, 4:23 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > > Line 80 (original), 83 (patched) > > <https://reviews.apache.org/r/58896/diff/1/?file=1704905#file1704905line83> > > > > Current code provides a framework to provide a configurable store to > > the processor. > > > > What is the reason for hardcoding DelegateSentryStore?
It may be better to have this discussion on the JIRA - I'll put my comment there. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58896/#review174492 ----------------------------------------------------------- On May 1, 2017, 11:42 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58896/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 11:42 p.m.) > > > Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, Sergio > Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1744 > https://issues.apache.org/jira/browse/SENTRY-1744 > > > Repository: sentry > > > Description > ------- > > SENTRY-1744 Simplify creation of DelegateSentryStore > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 3be6a0bf38d03f81df4aae3a878d1e6ecae52be7 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > b638be7456b4bbe27b48691b52912f06d43e09f1 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java > 8cf1c1a16a26939f4cf68278c7b8204ec0b08ca7 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java > de663138e63ccb998ec94ac42475071770a3526c > > > Diff: https://reviews.apache.org/r/58896/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
