> On May 19, 2017, 8:22 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > > Lines 217 (patched) > > <https://reviews.apache.org/r/59414/diff/1/?file=1725397#file1725397line217> > > > > If the thread is scheduled to be run in 500ms > > (refreshIntervalMillisec), how is this waitUtil going to work? I think this > > line is not needed as run() will be run in 500ms and the waitUntil will be > > already valid at that time. > > Alexander Kolbasov wrote: > I suspect that these waits in the run() method are nonsense that should > be removed, but they don't explain what we are seeing.
the waitUntil is used to wait longer if previous run failed. In normal case, it is not useful - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59414/#review175567 ----------------------------------------------------------- On May 19, 2017, 6:56 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59414/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 6:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar > kalvagadda, Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1771 > https://issues.apache.org/jira/browse/SENTRY-1771 > > > Repository: sentry > > > Description > ------- > > when curent time < wait until, return instead of sleeping. This avoid 6 > concurrent requests for full snapshot from HDFS. > Also synchronize the function SentryAuthorizationInfo.update() to make sure > requests always contain the latest changeID > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > 90ba721 > > > Diff: https://reviews.apache.org/r/59414/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
