> On May 24, 2017, 7:12 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestKrbConnectionTimeout.java > > Line 30 (original), 30-31 (patched) > > <https://reviews.apache.org/r/59508/diff/1/?file=1730897#file1730897line30> > > > > Is this change is not related to the HMSFollower refactor?.
There was TestKrbConnectionTimeout test failing upstream. This test used to fail randomly. I had to fix it. I will move it seperate jira. > On May 24, 2017, 7:12 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java > > Line 24 (original) > > <https://reviews.apache.org/r/59508/diff/1/?file=1730898#file1730898line24> > > > > Nothing changed here. will revert. > On May 24, 2017, 7:12 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > > Lines 104 (patched) > > <https://reviews.apache.org/r/59508/diff/1/?file=1730902#file1730902line104> > > > > What about moving this to the 'default:' section of switch? Also, > > remove the 'case INSERT'? The INSERT is not handled by Hive 1.1, and it is > > not necessary to support it. I recalled I already investigated this. will fix. > On May 24, 2017, 7:12 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > > Line 216 (original) > > <https://reviews.apache.org/r/59508/diff/1/?file=1730903#file1730903line218> > > > > There no change here. will revert. > On May 24, 2017, 7:12 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > > Lines 204 (patched) > > <https://reviews.apache.org/r/59508/diff/1/?file=1730904#file1730904line204> > > > > Can we set this constant in a constant variable? Also, how is this > > change related to the refactor? There was TestKrbConnectionTimeout test failing upstream. This test used to fail randomly. I had to fix it. I will move it seperate jira. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59508/#review175955 ----------------------------------------------------------- On May 23, 2017, 11:23 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59508/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 11:23 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1769 > https://issues.apache.org/jira/browse/SENTRY-1769 > > > Repository: sentry > > > Description > ------- > > Things included in refactoring. > 1. Moved the complete notification processing logic to notificationProcessor. > 2. Added new class HMSFollowerHelper class which does > HMS Client creation > HMS Client closure > Creating and persisting the HMS snapshot > 3. Misc cleanup > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 0bd0833 > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestKrbConnectionTimeout.java > b62a83f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java > 0d54548 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 8450402 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 58e8881 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollowerHelper.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > de8e2f7 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > 215f7d5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > dd37e7e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > 74a5afb > > > Diff: https://reviews.apache.org/r/59508/diff/1/ > > > Testing > ------- > > Made sure that all the tests around HMSFollower and SentryStore passed. > > > Thanks, > > kalyan kumar kalvagadda > >
