-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59576/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, 
Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.


Bugs: SENTRY-1785
    https://issues.apache.org/jira/browse/SENTRY-1785


Repository: sentry


Description
-------

There are couple of issues here
1. When Assume.assumeTrue fails the test is skipped but some times it is not 
skipped and the test fails.
2. setup(0 method in TestKrbConnectionTimeout calls setup again, which is 
reclusive call and there will be stack overflow.

Patch submitted has three changes
1. Updated the requires system property "sentry.hive.test.ticket.timeout" to 
true.
2. rename the BeforeClass annotated method of TestKrbConnectionTimeout class to 
avoid recursive call.
3. Invoked setup method to beginning of BeforeClass annotated method of 
TestKrbConnectionTimeout.


Diffs
-----

  
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestKrbConnectionTimeout.java
 b62a83f 
  
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
 dd37e7e 


Diff: https://reviews.apache.org/r/59576/diff/1/


Testing
-------


Thanks,

kalyan kumar kalvagadda

Reply via email to