> On May 24, 2017, 7:56 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2814 (patched) > > <https://reviews.apache.org/r/59510/diff/1/?file=1730920#file1730920line2814> > > > > According to the spec, getFirstMAuthzPathsMappingCore never returns > > null, so the first check is not needed and the second check is cleaner with > > using isEmpty().
Will fix > On May 24, 2017, 7:56 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2815 (patched) > > <https://reviews.apache.org/r/59510/diff/1/?file=1730920#file1730920line2815> > > > > Please do not use if statements to return true/false values, return > > conditions directly. > > > > return some_boolean_condition Will fix > On May 24, 2017, 7:56 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 97 (original), 96 (patched) > > <https://reviews.apache.org/r/59510/diff/1/?file=1730921#file1730921line97> > > > > With your change, why do we still need this? Not needed. Will fix - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59510/#review175982 ----------------------------------------------------------- On May 25, 2017, 1:41 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59510/ > ----------------------------------------------------------- > > (Updated May 25, 2017, 1:41 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1774 > https://issues.apache.org/jira/browse/SENTRY-1774 > > > Repository: sentry > > > Description > ------- > > HMSFollower should always depend on persisted information to decide is full > snapshot is needed instead of depending on in-memory information. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 8450402 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 58e8881 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 440b0e9 > > > Diff: https://reviews.apache.org/r/59510/diff/2/ > > > Testing > ------- > > Added new test to check new functionality added and also ran HMSFollower tests > > > Thanks, > > kalyan kumar kalvagadda > >
