> On May 26, 2017, 10:43 p.m., kalyan kumar kalvagadda wrote:
> > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryUpdater.java
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/59566/diff/1/?file=1732335#file1732335line56>
> >
> >     This log here feels to be redundent.

this is the info before processing updates from sentry server. The log at 
SentryAuthorizationInfo is after processing the update. I want to keep both to 
find any potential problem.


- Na


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59566/#review176234
-----------------------------------------------------------


On May 30, 2017, 7:08 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59566/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 7:08 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, 
> Sergio Pena, and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1784
>     https://issues.apache.org/jira/browse/SENTRY-1784
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> HDFS starts requesting changeID = 0 instead of 1. DBUpdateForwarder returns 
> full update if the request changeID <= 0.  After first full update, the 
> request changeID = 1, so only delta update is sent unless clean up removes 
> changes that are not sent to HDFS. This fixes both issues in this Jira.
> 
> 
> Diffs
> -----
> 
>   
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java
>  ad7f8c9 
>   
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java
>  90ba721 
>   
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryUpdater.java
>  34caa0e 
>   
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java
>  431c7fe 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
>  b8542b3 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  9beb07b 
> 
> 
> Diff: https://reviews.apache.org/r/59566/diff/2/
> 
> 
> Testing
> -------
> 
> TestHDFSIntegrationEnd2End
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to