-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59720/
-----------------------------------------------------------
(Updated June 7, 2017, 5:15 p.m.)
Review request for sentry and Alexander Kolbasov.
Changes
-------
This new patches addresses the following:
- It makes sure that a new HMS image is atomic, and it does not conflict with
other threads attempting to persist another image.
It uses a new table, MHiveMetastoreImage to address the above statement.
- Other comments mentioned by Sasha and Lina addressed.
Bugs: SENTRY-1781
https://issues.apache.org/jira/browse/SENTRY-1781
Repository: sentry
Description
-------
This patch only adds an extra column to the MAuthzPathsMapping table that
contains an image identifier that will be used to detect full snapshots. This
patch does not increment the identifier yet, it only uses 0 for now.
TIPS for reviewers:
- package.jdo adds a new column name AUTHZ_IMG_ID to the AUTHZ_MAPS_MAPPING
table used to identify the paths that are part of a new hive snapshot.
- MAuthzPathsMapping.java adds the the new column and API to handle JDO
requests.
- SentryStore.java modifies all methods that interact with the snapshots. It
makes sure that
when persisting a new snapshot, then the authzImgID is incremented and the
old one is
deleted. Also it makes sure that retrieve/add/delete/rename/update uses the
current
authzImgID whenver they're called.
- TestSentryStore.java adds unit tests to verify that all SentryStore API work
correctly
when a new hive snapshot is created.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java
f51894bb7e109c37997e7134e07a82f46c0a3c44
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MHiveMetastoreImage.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
96ab462d22afaf0f3004926f2855a8bb8cabc53b
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
97b3636062e75d228c58a947990369a990af3905
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
c5dddfb07bdfcb4c2bfee51f5cd7c684eff65a80
Diff: https://reviews.apache.org/r/59720/diff/3/
Changes: https://reviews.apache.org/r/59720/diff/2-3/
Testing
-------
All unit tests run locally, but there are some flaky tests on Jenkins no
related to this patch.
Thanks,
Sergio Pena
