----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177229 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java Line 30 (original), 34 (patched) <https://reviews.apache.org/r/59869/#comment250768> This doesn't need to be public sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java Lines 39 (patched) <https://reviews.apache.org/r/59869/#comment250771> Javadoc formatting guidelines: - The first line should be a short description of the method without any hyperlinks. - The rest should be formatted using HTML tags sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java Lines 47 (patched) <https://reviews.apache.org/r/59869/#comment250769> The method can be private changes can be Collection<T> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java Lines 48 (patched) <https://reviews.apache.org/r/59869/#comment250770> you know the exact size of the list, so please provide it here - new ArrayList<Long>(changes.size()) sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java Lines 59 (patched) <https://reviews.apache.org/r/59869/#comment250775> It seems that you need a different function - given list of ingerer IDs, return a string in the form "1-3, 5-7" Then the code can generate the list of IDs and call it. No one needs the list of lists thing. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java Lines 64 (patched) <https://reviews.apache.org/r/59869/#comment250773> This is internal func, so should be private - Alexander Kolbasov On June 7, 2017, 2:04 a.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59869/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 2:04 a.m.) > > > Review request for sentry, Alexander Kolbasov and Lei Xu. > > > Repository: sentry > > > Description > ------- > > * Changes on top of Lina's review (https://reviews.apache.org/r/59820/) > * Adds a couple of helper methods that would go under MSentryUtil > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > 6011ef407aaf82d211c81f6d6a55975fb21261b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > 7558267546fc8c4dedc4f739df6092851becfc31 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 37eb0b25e10ef69057599277aa5941ca05d52290 > > > Diff: https://reviews.apache.org/r/59869/diff/3/ > > > Testing > ------- > > In progress. > > > Thanks, > > Vamsee Yarlagadda > >
