> On June 7, 2017, 10:16 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_service.thrift > > Lines 68 (patched) > > <https://reviews.apache.org/r/59895/diff/1/?file=1744052#file1744052line68> > > > > You are changing on the wire ordering of fields - it may be better to > > preserve binary compatibility > > Sergio Pena wrote: > Done. I did this change. > > However, for curiosity, how is thrift compatible when a new column is > added at the end? The TPathsUpdate() thrift class still requires the new > parameter in order to be constructed. Or is the wire bytes ordered in the > same order I define my schema?
See https://diwakergupta.github.io/thrift-missing-guide/#_versioning_compatibility - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59895/#review177234 ----------------------------------------------------------- On June 8, 2017, 5:42 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59895/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 5:42 p.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Vamsee Yarlagadda. > > > Bugs: SENTRY-1782 > https://issues.apache.org/jira/browse/SENTRY-1782 > > > Repository: sentry > > > Description > ------- > > This adds the HMS image ID to the hdfs/sentry thrift definition. The value > will be used as part of the hdfs/sentry updates requests in order to detect > if a full paths image should be returned or not. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java > 29178d90b744b4b82b92ea24b1dc4f06dbebe36a > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java > f3014be9fec01bb32fa171d27bed9ac23bac4717 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > 6b31f7a4bbff66f6640813774ef79958990d7a57 > > sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_service.thrift > d01841b3bc4a8b38f44e08b45449e11352f6c725 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > 798bbef98b29af7c885c5ea747d77d2dad6c1693 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > 395618aa7271b1b739a08f98d284f12c37d31a7c > > > Diff: https://reviews.apache.org/r/59895/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
