----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60141/#review178402 -----------------------------------------------------------
These are the initial set of comments. I will look closer into the rest of it based on your response. - kalyan kumar kalvagadda On June 16, 2017, 12:02 a.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60141/ > ----------------------------------------------------------- > > (Updated June 16, 2017, 12:02 a.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Vamsee Yarlagadda. > > > Bugs: SENTRY-1805 > https://issues.apache.org/jira/browse/SENTRY-1805 > > > Repository: sentry > > > Description > ------- > > Define a new schema in package.jdo > Create a MAuthzPathsSnapshotId table > Upgrade all SQL scripts > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > f51894bb7e109c37997e7134e07a82f46c0a3c44 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsSnapshotId.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 459939b7600e05d57c7e11eefe20c2591cac0b34 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 8b19c88e52400ce096cf8f38fe2ca0313f7e46e1 > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql > 1bcbffb929d8a08e49fcb33b6306580863055e8c > > sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1805.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1805.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1805.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/009-SENTRY-1805.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 83cbfe7f8e89daee736f77b27dc3efd8696a45b7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > 1024e8ed48da720facf156a02a16b0e2884bb5f4 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 2c7c8b67f93d9e81aa0ad6fbccdba25df29c4c65 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > 590d48c9e7278af0225f28361e0317aeef5934b3 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > 125be9e6f3eec7e10213d10eddde2f8e51c6f303 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > c7d11d37babfc444e7f93d5bb417a826252c01d2 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql > dc3021a57ac9ea8145379c437ae6a94131c9ae5e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > ef1c651da8998eb57b5d0ca3463317d07c1b3a24 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql > f4a50de14dd0f961befaded394c6a01c2f459317 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql > db010bcd7792c9370478a2061e22d14bb78e3184 > > > Diff: https://reviews.apache.org/r/60141/diff/1/ > > > Testing > ------- > > TestSentrySchemaTool passed. > Run the rest of the tests manually on each DB. > > > Thanks, > > Sergio Pena > >
