----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60242/#review178454 -----------------------------------------------------------
Ship it! Please make sure that all tests are passing clean. - Alexander Kolbasov On June 20, 2017, 2:07 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60242/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 2:07 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1809 > https://issues.apache.org/jira/browse/SENTRY-1809 > > > Repository: sentry > > > Description > ------- > > In the Kafka tests, we use a custom "EmbeddedZkServer" class. It would be a > much better idea instead to leverage Apache Curator, which is already used in > Sentry to make testing using Zookeeper easier. > > > Diffs > ----- > > sentry-tests/sentry-tests-kafka/pom.xml 4c0ae777 > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/EmbeddedZkServer.java > 442ddff6 > > sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/KafkaTestServer.java > b82c0281 > > > Diff: https://reviews.apache.org/r/60242/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
