> On June 22, 2017, 8:02 a.m., Alexander Kolbasov wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java
> > Lines 276 (patched)
> > <https://reviews.apache.org/r/59508/diff/4/?file=1754610#file1754610line291>
> >
> > return else part since previous part ends with return
>
> kalyan kumar kalvagadda wrote:
> I did not quite get it.
if (someCondition)
{
...
return false;
} else if ((oldDbName.equals(newDbName))
Since there is a return, else clause is not needed. so it can be just
if (someCOndition) {
...
return false;
}
if (oldDbName.equals(newDbName)) {
...
}
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59508/#review178636
-----------------------------------------------------------
On June 22, 2017, 8:28 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59508/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 8:28 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li,
> Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1769
> https://issues.apache.org/jira/browse/SENTRY-1769
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Things included in refactoring.
> 1. Moved the complete notification processing logic to notificationProcessor.
> 2. Added new class HMSFollowerHelper class which does
> HMS Client creation
> HMS Client closure
> Creating and persisting the HMS snapshot
> 3. Misc cleanup
>
>
> Diffs
> -----
>
>
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java
> 0bd0833
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryHmsNotification.java
> 0d54548
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> 8b19c88
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullSnapshotInfo.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSClientWrapper.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> 1f7eb18
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollowerPersistenceException.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java
> 6762de7
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java
> 215f7d5
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SnapshotCreationException.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSClientWrapper.java
> PRE-CREATION
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java
> 66ad2a1
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestNotificationProcessor.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59508/diff/5/
>
>
> Testing
> -------
>
> Made sure that all the tests around HMSFollower and SentryStore passed. Added
> new classes to test new classes added.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
