Old infrastructure doesn't work. More over our approach for HA has changed. We current have some test classes for HA. They actually set the ha flag, None if the tests are actually using this flag in the tests except for one. There is some implementation available in InternalSentrySrv. There were some flaws in it.
I agree we should remove the old HA tests and write things from scratch. -Kalyan On Tue, Jun 27, 2017 at 1:06 AM, Alexander Kolbasov <[email protected]> wrote: > We have some old infrastructure for testing HA servers which is based on > the old design where clients find servers using Zookeeper. > > This no longer works, but we have some e2e tests that somehow attempt to > test it and even mysteriously pass. > > For the sentry-ha-redesign branch we have two options: > > > 1. Completely remove this code and then do something new from scratch. > 2. Try to reuse this infrastructure and retrofit it for the new HA code. > > For master branch (1.8) IMO, the whole old HA support should be just > removed, but we may deal with it later. > > I personally like option 1 above, but I have not looked into these tests > into any detail. > > The relevant class that implements it is InternalSentrySrv. > > Any thoughts about this? > > I filed a new JIRA https://issues.apache.org/jira/browse/SENTRY-1817 to > deprecate old HA support in sentry-ha-redesign branch. > > - Alex >
