> On June 27, 2017, 5:59 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestLeaderStatusMonitor.java > > Lines 44 (patched) > > <https://reviews.apache.org/r/60469/diff/2/?file=1764195#file1764195line44> > > > > Is this value too large? If the code has problem, the test will wait > > 500 * 1000, which is 500 seconds, before end. > > Alexander Kolbasov wrote: > What do you think is the reasonable value?
The zookeeper server is local, so there is minimum network delay. Three times of the interval usually should be enough. To be safe, based on the default value of zookeeper, total wait time of 3 * 60000 = 180000 is sufficient, which converts to NTRIES = 360. znode.container.checkIntervalMs (Java system property only) New in 3.6.0: The time interval in milliseconds for each check of candidate container nodes. Default is "60000". admin.idleTimeout (Java system property: zookeeper.admin.idleTimeout) Set the maximum idle time in milliseconds that a connection can wait before sending or receiving data. Defaults to 30000 ms. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60469/#review179002 ----------------------------------------------------------- On June 27, 2017, 4:57 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60469/ > ----------------------------------------------------------- > > (Updated June 27, 2017, 4:57 p.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1814 > https://issues.apache.org/jira/browse/SENTRY-1814 > > > Repository: sentry > > > Description > ------- > > SENTRY-1814 Provide unit test for LeaderStatusMonitor > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > e0f8a9e959146a8828adcee5258a165d273eac1f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > f78118ca0f03e1efe2384b2c7d3dff3730387bb3 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java > 5227c45e8d3e0e36e5abd46318a94a5e790bc676 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestLeaderStatusMonitor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60469/diff/2/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
