----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60503/#review179260 -----------------------------------------------------------
Thanks Venkatesh for starting to work on this. I just wonder what happened with the SentryMetastorePostEventListenerNotificationLog file? Shouldn't we delete the file as well? Also, why are we making changes on SentryMetastorePostEventListener? Seems the patch does not reflect the intention of the jira. - Sergio Pena On June 28, 2017, 3:42 p.m., Venkatesh Ramasamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60503/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 3:42 p.m.) > > > Review request for sentry and Sergio Pena. > > > Bugs: SENTRY-1787 > https://issues.apache.org/jira/browse/SENTRY-1787 > > > Repository: sentry > > > Description > ------- > > This is to refactor SentryMetastorePostEventListenerNotificationLog class > within Sentry. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > 21bfa64d > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > fe68f497 > > > Diff: https://reviews.apache.org/r/60503/diff/1/ > > > Testing > ------- > > > Thanks, > > Venkatesh Ramasamy > >
