----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60752/ -----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Na Li. Repository: sentry Description ------- The MetastorePlugin.SyncTask class is a thread running in the background in the HMS side that is used to keep HMS/Sentry in sync with HDFS, or any other words, it pushes a full HMS snapshot to Sentry every time Sentry is out-of-sync. However when a timed out exception is thrown when sending the snapshot to Sentry, a retry happens in the next thread run() iteration. The problem is that these exceptions do not terminate the Thrift thread sending the data, and a new retry will generate a new Thrift thread be created. We should close those threads by resetting the connection when an error occurs. Diffs ----- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java 7a21871b8 Diff: https://reviews.apache.org/r/60752/diff/1/ Testing ------- Thanks, Arjun Mishra
