> On July 7, 2017, 9:32 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > > Lines 241 (patched) > > <https://reviews.apache.org/r/60669/diff/1/?file=1769872#file1769872line241> > > > > This seems a duplication of SENTRY_DELTA_KEEP_COUNT. Why do we need a > > different one? Can we reuse SENTRY_DELTA_KEEP_COUNT? > > kalyan kumar kalvagadda wrote: > I prefer having a different value for this. I don't see a reason to > re-use the same value as SENTRY_DELTA_KEEP_COUNT.
I understand the different value, but what about the variable name? 'sentry.server.delta.keep.count' is the same on both constants. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60669/#review179947 ----------------------------------------------------------- On July 8, 2017, 3:31 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60669/ > ----------------------------------------------------------- > > (Updated July 8, 2017, 3:31 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1762 > https://issues.apache.org/jira/browse/SENTRY-1762 > > > Repository: sentry > > > Description > ------- > > SENTRY_HMS_NOTIFICATION_ID table will be updated with the ID's for every > notification that sentry processes. This data grows with time. > we need to periodically purge this data as it will effect the performance. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 1402ab1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > ec938da > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 83f00ca > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > ac266fe > > > Diff: https://reviews.apache.org/r/60669/diff/2/ > > > Testing > ------- > > Added new tests to test the code change added. > > > Thanks, > > kalyan kumar kalvagadda > >
