> On July 12, 2017, 4:25 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java > > Line 148 (original), 148-150 (patched) > > <https://reviews.apache.org/r/60779/diff/4/?file=1774583#file1774583line152> > > > > Should we do this at the constructor level? Otherwise we would end uo > > having duplicate thread names for multiple invocations of this method.
This method is only called from constructor. This is not ideal, but there is no danger that it is called multiple times. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60779/#review180312 ----------------------------------------------------------- On July 12, 2017, 6:31 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60779/ > ----------------------------------------------------------- > > (Updated July 12, 2017, 6:31 a.m.) > > > Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, > Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1798 > https://issues.apache.org/jira/browse/SENTRY-1798 > > > Repository: sentry > > > Description > ------- > > SENTRY-1798: Provide names for HMSFollower and cleaner threads > > This is an updated version of https://reviews.apache.org/r/60091/. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > 680db7a854c4313012a36c52ab167ca43503c299 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > 0e5d6060faab5472b5f5c4e09b8029a3322481b4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java > 1490581cc9bb882f4c14a180ade43aa4e8c18a82 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java > edb8006d95770a17ec4525be53887cb258bbe3e7 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 322197bd04754315d923563094bcade87510deec > > > Diff: https://reviews.apache.org/r/60779/diff/4/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
