----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60840/#review180560 -----------------------------------------------------------
It would great if you could include pom file changes. I made similar effort to integrate with Hive 2.1.1 and it needed a lot of changes. I'm working on a series of commits to support Hive2.1.1 my self. sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java Line 536 (original), 536 (patched) <https://reviews.apache.org/r/60840/#comment255755> HIVEQUERYSTRING is not vallue we need here. sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/SentryHiveAuthorizer.java Lines 203 (patched) <https://reviews.apache.org/r/60840/#comment255756> I'm snot sure we should be retuning true. here. - kalyan kumar kalvagadda On July 13, 2017, 2:25 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60840/ > ----------------------------------------------------------- > > (Updated July 13, 2017, 2:25 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1837 > https://issues.apache.org/jira/browse/SENTRY-1837 > > > Repository: sentry > > > Description > ------- > > The sentry-binding-hive-v2 does not currently work with Hive 2.1.x, as it > lacks a few methods in the authorizer and also references a method in > SessionState that was subsequently removed. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java > c63cf642 > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java > 6c2410b0 > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/SentryHiveAuthorizer.java > 14b952f5 > > > Diff: https://reviews.apache.org/r/60840/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
