> On July 14, 2017, 3:49 p.m., Colm O hEigeartaigh wrote: > > Is there a reason the PMD failOnViolation flag has changed to false? > > kalyan kumar kalvagadda wrote: > There were a lot of failures because of that. To maintain the focus of > this patch I had to supress PMD violations. I will open another jira to fix > the PMD violations. > > Colm O hEigeartaigh wrote: > In the Hive v2 binding module? If so it'd be better just to disable PMD > for that particular module, by setting the pmd.skip property to true in a > profile activated by default.
I did not know it can be done that way. I will make the change. Otherwise what do you say about the patch? - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60865/#review180534 ----------------------------------------------------------- On July 14, 2017, 3:31 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60865/ > ----------------------------------------------------------- > > (Updated July 14, 2017, 3:31 p.m.) > > > Review request for sentry and Sergio Pena. > > > Bugs: SENTRY-1834 > https://issues.apache.org/jira/browse/SENTRY-1834 > > > Repository: sentry > > > Description > ------- > > Planning to enable hive-auth2 profile in upstream sentry-ha-redesign branch. > As we are supporting hive auth V2 in that branch we need to keep it up to > date. Disabling it is making the Hive-Authv2 binding implementation stale. > Here are some os the issue disabling it. > 1. Hive BindingV2 Code is not fixed when Hive BindingV1 is fixed. > 2. Hive BindingV2 will not be green. > Fixing would be a bigger issue. If they are enabled contributors will make > sure that related cpde for Hive-Authv2 is also fixed/updated properly. > > > Diffs > ----- > > pom.xml 2c109a4 > sentry-binding/pom.xml 71fe47c > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryAccessController.java > c63cf64 > sentry-dist/pom.xml 2d7f57e > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 1415297 > > > Diff: https://reviews.apache.org/r/60865/diff/2/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
