----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60955/#review181534 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java Lines 61 (patched) <https://reviews.apache.org/r/60955/#comment257137> Please specify under what conditions null is returned. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java Lines 82 (patched) <https://reviews.apache.org/r/60955/#comment257138> missing line sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java Lines 83 (patched) <https://reviews.apache.org/r/60955/#comment257139> "Handle" is a generic term, adding a line or two about what it actually does is more helpful. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java Lines 101 (patched) <https://reviews.apache.org/r/60955/#comment257140> Do we need to return some kind of HTTP error in this case? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java Lines 105 (patched) <https://reviews.apache.org/r/60955/#comment257141> Here you are sending inputs to outputs as is which may be a subject to cross-scripting vulnerabilities. You need to url-escape it - see SENTRY-1665 for an example. sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerLogLevel.java Lines 61 (patched) <https://reviews.apache.org/r/60955/#comment257142> Please document what is the test case actually testing like - Send level and class via the HTTP interface and verify that it is set at the loogger. - Alexander Kolbasov On July 26, 2017, 2:28 a.m., Donghui Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60955/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 2:28 a.m.) > > > Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and > Na Li. > > > Bugs: SENTRY-1853 > https://issues.apache.org/jira/browse/SENTRY-1853 > > > Repository: sentry > > > Description > ------- > > Add the log level setting and reading mechanism, through which users can > control the log content. > This mechanism provides the url interface,through which users can dynamically > set the log level. Service restores the original log level after restart. > > The format of the interface is as follows: > 1. Read the log level. URL address is http: //HOST: PORT/logLevel? Log = > CLASS_NAME > 2. Set the log level. URL address is http: //HOST: PORT/logLevel? Log = > CLASS_NAME & level = LOG_LEVEL > > The above parameters include: > HOST: host name or ip address of sentry server. > PORT: port of sentry server. > CLASS_NAME: name of class whose log level is read or set. > LOG_LEVEL: the log level to be set. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/LogLevelServlet.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 8b4d374 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerLogLevel.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60955/diff/2/ > > > Testing > ------- > > > Thanks, > > Donghui Xu > >
