-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61537/
-----------------------------------------------------------

(Updated Aug. 11, 2017, 12:28 a.m.)


Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio 
Pena, and Vamsee Yarlagadda.


Changes
-------

- Addressed code review feedback from Brian
- Added unit tests for all operations for FullUpdateModifier
- Fixed issues found by unit test


Bugs: SENTRY-1874
    https://issues.apache.org/jira/browse/SENTRY-1874


Repository: sentry


Description
-------

SENTRY-1874 Do not require quiet HMS when taking initial HMS snapshot


Diffs (updated)
-----

  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
 5af1e4ff36d53e399f1f51b023aaf379ebf62b92 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java
 PRE-CREATION 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 b0a202eef391accce3cea5e62374acf37e3d1b38 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
 4f76a94c9c97f9ad8ab491f8ad444e80c30e258e 
  
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61537/diff/4/

Changes: https://reviews.apache.org/r/61537/diff/3-4/


Testing (updated)
-------

Added unit tests for FullUpdateModifier.


Thanks,

Alexander Kolbasov

Reply via email to