----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61724/#review183214 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3033 (patched) <https://reviews.apache.org/r/61724/#comment259232> This method is the same as isNotificationIDTableEmpty(). Can we we just make isNotificationIDTableEmpty() public and use it instead? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java Line 784 (original), 785 (patched) <https://reviews.apache.org/r/61724/#comment259234> Do we need this mock? This method is not used anymore on the HMSFollower. I think is safe to remove it and any other mock to isAuthPathsMappingEmpty() as well. - Sergio Pena On Aug. 18, 2017, 12:51 a.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61724/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 12:51 a.m.) > > > Review request for sentry, Brian Towles, Sergio Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > when deciding if we should take full snapshot of HMS, check notification > table intead of the authorization path table because notification table is > always updated regardless HDFS is enabled or not > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > e9de73a > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 1d8200d > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > 48b009f > > > Diff: https://reviews.apache.org/r/61724/diff/1/ > > > Testing > ------- > > unit tests > > > Thanks, > > Na Li > >
