> On Aug. 23, 2017, 6:35 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 537 (patched) > > <https://reviews.apache.org/r/61827/diff/1/?file=1801885#file1801885line541> > > > > Looks like most callers just care whether size() != 0, so you may have > > even simpler isEmpty() function.
In principle, yes, but let's have some more flexibility for the future. Looks like size == 1 is a very frequent case and maybe the rest of the Sentry code will benefit from easily accessible knowledge about it. - Misha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61827/#review183637 ----------------------------------------------------------- On Aug. 22, 2017, 11:02 p.m., Misha Dmitriev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61827/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 11:02 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, and Vadim > Spector. > > > Bugs: SENTRY-1892 > https://issues.apache.org/jira/browse/SENTRY-1892 > > > Repository: sentry > > > Description > ------- > > SENTRY-1892: Reduce memory consumption of HMSPath and TPathEntry > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java > 2a89368208bcef5b537cb0c2d59fd14b1735f435 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > 6e71561e36d7f235afb14961299bfc23c03607a6 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPathsDumper.java > bf6c3dec35c7d22b9bd0e3f863925f7ff3e94515 > > sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_service.thrift > 22dea02ea003530513d7fb270eb0ca0ce38957e9 > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPaths.java > a0d7bdcd256a17558178ebc5238b1f3da9fa5e9b > > > Diff: https://reviews.apache.org/r/61827/diff/1/ > > > Testing > ------- > > Ran 'mvn install' locally, all tests passed. > > > Thanks, > > Misha Dmitriev > >
