> On Aug. 23, 2017, 8:22 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Line 302 (original), 302 (patched) > > <https://reviews.apache.org/r/61858/diff/1/?file=1802493#file1802493line302> > > > > Is there any reason not to do this for permission changes?
Do we have such storage issue with Permission changes? Based on https://stackoverflow.com/questions/3156815/why-does-varchar-need-length-specification, There's possible performance impact: in MySQL, temporary tables and MEMORY tables store a VARCHAR column as a fixed-length column, padded out to its maximum length. If you design VARCHAR columns much larger than the greatest size you need, you will consume more memory than you have to. This affects cache efficiency, sorting speed, etc. > On Aug. 23, 2017, 8:22 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > > Line 16 (original), 16 (patched) > > <https://reviews.apache.org/r/61858/diff/1/?file=1802495#file1802495line16> > > > > Do we need mediumtext? Would TEXT (64K max) be sufficient? I copied the type from HMS. Actually, the type is "longtext", not "mediumtext". I will update accordingly. see column "message" in "CREATE TABLE IF NOT EXISTS `NOTIFICATION_LOG`" at https://github.com/apache/hive/blob/master/metastore/scripts/upgrade/mysql/hive-schema-2.2.0.mysql.sql > On Aug. 23, 2017, 8:22 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > > Line 17 (original), 17 (patched) > > <https://reviews.apache.org/r/61858/diff/1/?file=1802496#file1802496line17> > > > > Would VARCHAR2 work here? I copied the type in Hive https://github.com/apache/hive/blob/master/metastore/scripts/upgrade/oracle/hive-schema-2.2.0.oracle.sql CREATE TABLE NOTIFICATION_LOG ( NL_ID NUMBER NOT NULL, EVENT_ID NUMBER NOT NULL, EVENT_TIME NUMBER(10) NOT NULL, EVENT_TYPE VARCHAR2(32) NOT NULL, DB_NAME VARCHAR2(128), TBL_NAME VARCHAR2(256), MESSAGE CLOB NULL, <- use CLOB MESSAGE_FORMAT VARCHAR(16) NULL ); - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61858/#review183653 ----------------------------------------------------------- On Aug. 23, 2017, 7:46 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61858/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 7:46 p.m.) > > > Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vamsee > Yarlagadda. > > > Repository: sentry > > > Description > ------- > > change sql schema to allow path_change contain larger value > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 77ec491 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > 4afa2e0 > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > 8636fec > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > c3c374b > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > d168bf5 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.0.0.sql > 69ef5b7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.0.0.sql > 0db7ba9 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql > 183481a > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.0.0.sql > cf4f0ed > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.0.0.sql > 5974ed9 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-2.0.0.sql > 20c50b7 > > > Diff: https://reviews.apache.org/r/61858/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
