> On Sept. 1, 2017, 6:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 1811 (original), 1811 (patched) > > <https://reviews.apache.org/r/61863/diff/3/?file=1808743#file1808743line1811> > > > > Can we use > > > > pm.setDetachAllOnCommit(false); > > > > here?
It is already included before the getRoleNamesForGroupsCore(pm, groups) is called by getRoleNamesForGroups(final Set<String> groups) method > On Sept. 1, 2017, 6:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 1828 (patched) > > <https://reviews.apache.org/r/61863/diff/3/?file=1808743#file1808743line1828> > > > > `sentrGroup` is a weird name. Of course this is sentry, so group is a > > perfect name. When I used just "group" I got an exception complaining about group being a keyword "javax.jdo.JDOUserException: JDOQL query contains the identifier "group", yet this is a keyword. The query is invalid." - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61863/#review184334 ----------------------------------------------------------- On Aug. 31, 2017, 9:55 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61863/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2017, 9:55 p.m.) > > > Review request for sentry, Alexander Kolbasov, Vamsee Yarlagadda, and Vadim > Spector. > > > Repository: sentry > > > Description > ------- > > Right now when we get privileges from sentry, we pass in a provider like set > of groups. Then we create a MSentryGroup object for each group and then get > roles using the .getRoles() method. However, DataNucleus takes too long and > the fetch doesn't seem to be lazy. This is bad since we only need the > roleNames for the group and not the entire Role object. > Instead running a SQL like query and just getting roleNames will drastically > improve performance > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > d7acaea7c > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 8f60b5801 > > > Diff: https://reviews.apache.org/r/61863/diff/3/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
