> On Sept. 5, 2017, 10:28 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 46 (patched) > > <https://reviews.apache.org/r/62096/diff/1/?file=1815913#file1815913line46> > > > > I think it is a bit cleaner to change the name and reverse the value, > > something like > > > > pathRetrieverIsBusy = newAtomicBoolean(true) > > > > This will express the meaning better IMO.
+1 - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62096/#review184595 ----------------------------------------------------------- On Sept. 5, 2017, 10:41 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62096/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2017, 10:41 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, and > Vamsee Yarlagadda. > > > Bugs: sentry-1919 > https://issues.apache.org/jira/browse/sentry-1919 > > > Repository: sentry > > > Description > ------- > > The patch uses an atomic boolean flag that prevents multiple HDFS requests to > get the paths updates (either deltas or full images) by returning an empty > paths updates list if the flag is set as not available. > > The reason to prevent for deltas as well is because the code change was much > easier to do in once place (SentryHDFSServiceProcessor). We shouldn't get any > issues if we do it this way (unless the reviewer thinks otherwise). > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > 6221f3d01 > > > Diff: https://reviews.apache.org/r/62096/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
