> On Sept. 6, 2017, 12:28 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 297 (patched) > > <https://reviews.apache.org/r/62107/diff/2/?file=1816086#file1816086line297> > > > > Can you add check (with preconditions) that it is set to false at the > > beginning - like an assert statement?
Im not sure its really nessesary but im adding the assert so that if it does occur we can catch it quick enough. > On Sept. 6, 2017, 12:28 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceFactory.java > > Line 24 (original), 33 (patched) > > <https://reviews.apache.org/r/62107/diff/2/?file=1816088#file1816088line36> > > > > should this be static as well? > > Do we need to be concerned with concurrency? It should be. Right now we I already added a ticket for later. SENTRY-1921. I felt since it touched a bunch more files it would be better served as its own work with thought into overall access mechansims. I dont think we need to be concerned with concurrency as its essentially a singleton pattern for the service thread. The SentryService thread is only run once on a newSingleThreadExecutor. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184628 ----------------------------------------------------------- On Sept. 5, 2017, 9:25 p.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62107/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2017, 9:25 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio > Pena, and Vadim Spector. > > > Bugs: SENTRY-1918 > https://issues.apache.org/jira/browse/SENTRY-1918 > > > Repository: sentry > > > Description > ------- > > Added fix to limit sending back of full snapshot when the HMSFollower is > pulling a full snapshot > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 5d744214e14d6c48194b3a0bf84d6e10070b020a > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > 8fbc10048003ab4b8a38676e241ae0fd27d2392c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > d4feb380fa0f3bd5f237609a107295a2d23eae3b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > d44abffc199cd46d3ab7d2230dfdb2075736a8f0 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceFactory.java > 1685702c6dbc9715c8885a29a80bc68509550f0b > > > Diff: https://reviews.apache.org/r/62107/diff/2/ > > > Testing > ------- > > Unit Tests > > > Thanks, > > Brian Towles > >
