> On Sept. 13, 2017, 6:50 p.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Line 74 (original), 78 (patched) > > <https://reviews.apache.org/r/62221/diff/8/?file=1821068#file1821068line78> > > > > Can remove String.format and make it via simple {}? > > Arjun Mishra wrote: > Logger.debug won't work for more than 2 parameters. Let me know if you > want me to change it to something else
Good to know. This kinda of explains the behaviour. https://stackoverflow.com/a/10555492 - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62221/#review185327 ----------------------------------------------------------- On Sept. 13, 2017, 8:33 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62221/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 8:33 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, Sergio > Pena, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Sentry Supportability improvement. > > 1. HMSFollower > * Print confirmation message (at INFO level) once full snapshot is persisted > in the DB. > * Print the message that HMSFollower is completely ready (after the initial > pass of HMSFollower is done) > > 2. DBUpdateForwarder > * Every log message should explicitly mention which type of events is it > referring to (PERM or PATH) otherwise there is no way for us to differentiate > between calls. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 8a34d5623 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > 1318082d3 > > > Diff: https://reviews.apache.org/r/62221/diff/9/ > > > Testing > ------- > > > File Attachments > ---------------- > > SENTRY-1938.07.patch > > https://reviews.apache.org/media/uploaded/files/2017/09/13/2f4d17ae-ce15-4b21-b2e0-2e53b4203ac7__SENTRY-1938.07.patch > > > Thanks, > > Arjun Mishra > >
