> On Sept. 22, 2017, 3:55 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > > Line 319 (original), 337 (patched) > > <https://reviews.apache.org/r/62496/diff/2/?file=1832780#file1832780line346> > > > > This is similar to "tmpFile = Files.createTempFile(tmpDir, "hmetrics", > > "json", FILE_ATTRS);" in https://reviews.apache.org/r/62487/diff/2#0 > > > > This means both temporary file has the same name. Is the temDir of the > > same value? > > > > SENTRY_JSON_REPORTER_FILE_DEFAULT = "/tmp/sentry-metrics.json"; > > > > This means the temDir is <log home>/tmp, so sentry temp metric file > > will be of the same name with hive temp metric file. Is this correct? > > > > Can we use the temFile name defined in > > ServerConfig.SENTRY_JSON_REPORTER_FILE and > > ServerConfig.SENTRY_JSON_REPORTER_FILE_DEFAULT?
createTempFile creates a file with unique name every time it is called. but we can change prefix as well to be clear what this file is. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62496/#review185997 ----------------------------------------------------------- On Sept. 22, 2017, 6:28 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62496/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2017, 6:28 p.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar > kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1963 > https://issues.apache.org/jira/browse/SENTRY-1963 > > > Repository: sentry > > > Description > ------- > > SENTRY-1963: Sentry JSON reporter should use regular implementation for local > file system > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > 4063a663c86ea5ed88c40013d5b3550ac0a6272f > > > Diff: https://reviews.apache.org/r/62496/diff/3/ > > > Testing > ------- > > New unit test written > > > Thanks, > > Alexander Kolbasov > >
