----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62745/ -----------------------------------------------------------
Review request for sentry. Bugs: SENTRY-1210 https://issues.apache.org/jira/browse/SENTRY-1210 Repository: sentry Description ------- For generic model, one shell like SentryShellGeneric should be covered all related components, eg, solr, kafka. SentryShellSolr and SentryShellKafka should be replaced with the SentryShellGeneric Diffs ----- bin/sentryShell f0661568 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java f6e5d1b6 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java 5385f7d7 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java 6ddc1def sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java 7db54260 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java d4e26e82 Diff: https://reviews.apache.org/r/62745/diff/1/ Testing ------- Tested that the binary "sentryShell" can list privileges correctly for both Kafka and Solr. Thanks, Colm O hEigeartaigh