----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62767/ -----------------------------------------------------------
(Updated Oct. 4, 2017, 12:04 p.m.) Review request for sentry. Bugs: SENTRY-1973 https://issues.apache.org/jira/browse/SENTRY-1973 Repository: sentry Description ------- This task is to use the KafkaPrivilegeModel to retrieve the Kafka validators instead of hard-coding them in KafkaTSentryPrivilegeConverter. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConverter.java 688bc9e4 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConverter.java 92c6c599 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java 183e83d3 Diff: https://reviews.apache.org/r/62767/diff/2/ Changes: https://reviews.apache.org/r/62767/diff/1-2/ Testing ------- Tested the SentryShell works ok. Thanks, Colm O hEigeartaigh