----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62983/#review187993 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java Line 142 (original), 142 (patched) <https://reviews.apache.org/r/62983/#comment265049> This means that privilegeObj can never be null. But this also shows that dump() is called for no reason all the time here and it is potentially expensive and should be removed. - Alexander Kolbasov On Oct. 13, 2017, 6:10 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62983/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 6:10 p.m.) > > > Review request for sentry and kalyan kumar kalvagadda. > > > Bugs: sentry-1986 > https://issues.apache.org/jira/browse/sentry-1986 > > > Repository: sentry > > > Description > ------- > > Fix NPE > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > ceb3b17714d5dfc4c6186b5f9cf536d6ddbb662b > > > Diff: https://reviews.apache.org/r/62983/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
