> On Oct. 26, 2017, 3:21 p.m., Sergio Pena wrote: > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > > Lines 209 (patched) > > <https://reviews.apache.org/r/63308/diff/1/?file=1868962#file1868962line209> > > > > typo: exceptinon > > > > Why we don't have the same 'Expected message ...' that we have in the > > assertCausedMessage() ? > > > > Why are we using compareTo() instead of contains() like > > assertCausedMessage()?
I will the type. In this case we are checking if one of the two possible exceptions ae thrown. I tought following the convention assertCausedMessage can cause confusion. I will change it. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63308/#review189300 ----------------------------------------------------------- On Oct. 26, 2017, 2:02 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63308/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2017, 2:02 p.m.) > > > Review request for sentry, Colm O hEigeartaigh and Sergio Pena. > > > Bugs: SENTRY-2020 > https://issues.apache.org/jira/browse/SENTRY-2020 > > > Repository: sentry > > > Description > ------- > > with the new Kafka version, multiple threads will be requesting sentry for > authorization at the same time for a same authorizable so the it is not > guarentted to get the same exception when multiple permissions are missing. > Code change is added to make sure that test suceeds if any one of the > expected exception is thrown. > > > Diffs > ----- > > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java > 100d885 > > sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/TestAuthorize.java > 53f1f47 > > > Diff: https://reviews.apache.org/r/63308/diff/1/ > > > Testing > ------- > > Made sure the e2e tests ae passing. > > > Thanks, > > kalyan kumar kalvagadda > >
