----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63709/#review190839 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo Line 54 (original), 60 (patched) <https://reviews.apache.org/r/63709/#comment268416> index for user name is not SENTRY_USER_USER_NAME_UNIQUE for derby and DB2, SENTRYUSERNAME. You may have to update the sql scripts so that jdo and sql scripts are in-line. Please the same for other indexes as well. - kalyan kumar kalvagadda On Nov. 9, 2017, 10:50 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63709/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 10:50 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Repository: sentry > > > Description > ------- > > Many of the index names in package.jdo for dataNucleus are different from the > corresponding index names in sql script. > If dataNucleus is configured to add schema info into DB, it will result in > creating additional index for the same purpose in some DB (like MySql), or > cause exception for other DB (like Oracle) > > It is better to make the same index having the same name in package.jdo and > sql script > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 2f2aabb > > > Diff: https://reviews.apache.org/r/63709/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
