----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63762/#review190951 -----------------------------------------------------------
Ship it! Ship It! - kalyan kumar kalvagadda On Nov. 13, 2017, 7:17 p.m., Hrishikesh Gadre wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63762/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 7:17 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. > > > Bugs: SENTRY-2042 > https://issues.apache.org/jira/browse/SENTRY-2042 > > > Repository: sentry > > > Description > ------- > > - As part of SENTRY-1475, we upgraded the Sentry/Solr integration to use the > latest version of SOLR (7.1.0 at the time of writing). But this did not > include the support for file-based Sentry provider backend. This patch > implements this functionality. > - Added an E2E test to verify Solr plugin with file based Sentry > - Removed the logic to check and skip the broken locales (since we are > hardcoding the locale value in pom.xml). > > > Diffs > ----- > > sentry-binding/sentry-binding-solr/pom.xml > 2452e2f6de4f56925291ac4a77757149c746ac30 > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SentrySolrPluginImpl.java > c0ead285e5e6745703773b5160395fb5495086c1 > sentry-tests/sentry-tests-solr/pom.xml > 723fa9d1991315ed2a182fd5ffcf9974848dbe77 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestCase.java > e6e7a70b392f41112a8fe5b6d79b4552d153f4cc > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/SolrSentryServiceTestBase.java > PRE-CREATION > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java > a24ceee9f959dab53d7f63ea6d46eef58c0f34ce > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSolrAdminOperations.java > 190b9d474534e51b6a4501e6bbe95b836ea8a123 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSolrCollectionOperations.java > 3d9faa01668a28c638a58c11e86a5089d367ec02 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSolrConfigOperations.java > 620825fea5f33244826fc829e7482a6611507660 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSolrSchemaOperations.java > 1169b54c5d306f0d3d0e4bf833eeb7a5058890f8 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestSolrWithSimpleFileProviderBackend.java > PRE-CREATION > > sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini > a376cb8cfa7e5f905d177efa8fbdce24aef74199 > > > Diff: https://reviews.apache.org/r/63762/diff/1/ > > > Testing > ------- > > All unit tests are passing. > > > Thanks, > > Hrishikesh Gadre > >
