----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63645/ -----------------------------------------------------------
(Updated Nov. 16, 2017, 8:38 p.m.) Review request for sentry, Alexander Kolbasov, Sergio Pena, and Vadim Spector. Changes ------- Updates post Vadim's feedback Repository: sentry Description ------- When retrieving full path image update, we split a path by "/" and create HMS Path entries. However, the leading "/" presence will cause issues because on splitting the value at index 0 will be empty. This will affect the creation of HMS path entries. Diffs (updated) ----- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java cef8bd734 sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java 8419b9d5e sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java cf83e7796 Diff: https://reviews.apache.org/r/63645/diff/3/ Changes: https://reviews.apache.org/r/63645/diff/2-3/ Testing ------- mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore mvn -f sentry-core/sentry-core-common/pom.xml test -Dtest=TestPathUtils Thanks, Arjun Mishra
